Feat: React 19 Upgrade #2363

kierancap · 2025-03-20T15:21:16Z

Why

Closing #2341

What

Main changes:

Removed all usage of forwardRef - As per the React docs, will be fully deprecated in future.
Replaced all ref fields with the valid React Types - Any polymorphic components were set as any for the RefObject generic.
Added valid initial values for all usages of useRef which were missing inits.
Refactored the SpringContext to resemble a more sensible Context structure

Checklist

Removed forwardRef
Added correct ref fields
Added initial values for useRef
Refactored SpringContext

Additional Comments

This was based on this PR: #2349

As the PR and issue have been open for a good while now, it's obvious that no further development was going to happen - I'm currently blocked by this library, so I thought it'd try and help with moving this forward.

PR Diff

I'm unsure as to why the diff is heavily focused on formatting changes - I was sure to run prettier via the NPM script before submitting this PR. Happy to outline all the direct code changes if necessary.

feat: Bumped deps and refactored usages of forwardRef

changeset-bot · 2025-03-20T15:21:19Z

⚠️ No Changeset found

Latest commit: c78dad7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel · 2025-03-20T15:21:20Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
react-spring	✅ Ready (Inspect)	Visit Preview	Mar 20, 2025 3:23pm

thomazcapra · 2025-03-25T15:02:19Z

👀

abriginets · 2025-03-25T18:52:45Z

@joshuaellis apologies for reaching out directly, but if you have some time, could you please take a look at this PR? We'd really appreciate your review when it’s convenient for you. Thanks a lot!

johansunden · 2025-03-27T09:09:25Z

Is @joshuaellis the only person who can review this? Would be great to get this in and not have it end up like the other attempt at upgrading to React 19

kierancap · 2025-03-27T20:04:22Z

Is @joshuaellis the only person who can review this? Would be great to get this in and not have it end up like the other attempt at upgrading to React 19

Yeah... I was hoping that the fact this PR passed all the tests would mean it'd get reviewed sooner rather than later. At this rate someone may as well fork this library fully and re-distribute it. Shambolic from the maintainers if I'm honest

joshuaellis · 2025-03-27T20:22:24Z

Hey, firstly – sorry I recently started a family & I also have a FT job so unfortunately, open-source software is taking a back seat. Secondly, thanks for the PR! Here's some follow up questions:

Have you tried running this library with a react16|17|18 app? I'm wondering if these changes to forwardRef will mean this is a breaking change to the library?
I think your changes to SpringContext are probably breaking changes because previously <SpringContext> was possible – now it's not? Maybe i'm misunderstanding the change though.
"Shambolic from the maintainers if I'm honest" – how many maintainers do you think react-spring has?

Also, some other things i think we're missing from this is:

updating the package.json of the packages to add react19 as an acceptable peer-dep
There's a console warning about act in the useTransition test, be good to tackle that

Otherwise, this looks super promising!

kierancap · 2025-03-27T20:58:37Z

Appreciate the reply, great to hear from you. Congratulations on the family news!

I'd be happy to test out those changes regarding older version of React once I get the opportunity.

The context change is breaking due to the nature of changing the Provider to be separate from the instantiated context itself. It follows the Context Provider pattern; Here's an article around it - I find it to be way better for DX. If you'd prefer it to remain as it was previously, it may involve a bit more in-depth tinkering due to the type errors generated from the current approach. I'm not torn on either approach - As long as the resulting code is readable and maintainable for future development. I can take a look at refactoring the types and structure to potentially allow for a single object to safely contain all the necessary functionality.

In terms of my comment about the maintenance of this project, it's more targeted to the complete lack of communication towards the community. The main issue attached to this PR has hundreds of people waiting for this change, after you had mentioned about updating it in December. Granted I appreciate your new family changes meant you were not available, but I do think that the lack of communication severely impacted this whole process.

As I was forced to make this change due to a work dependancy on a 1st party library, I cannot guarantee that I'll have time to look at this in the short term. I'll do my best.

Hopefully I can have time next week to delve deeper into the good points you mentioned.

I'll try to keep this PR up to date with that

joshuaellis · 2025-03-27T21:07:23Z

The context change is breaking due to the nature of changing the Provider to be separate from the instantiated context itself. It follows the Context Provider pattern; Here's an article around it - I find it to be way better for DX. If you'd prefer it to remain as it was previously, it may involve a bit more in-depth tinkering due to the type errors generated from the current approach. I'm not torn on either approach - As long as the resulting code is readable and maintainable for future development. I can take a look at refactoring the types and structure to potentially allow for a single object to safely contain all the necessary functionality.

tbf i'm kind of happy to remove it, I don't think anyone uses it. Also it breaks everything in RCS for imo not a lot of gain...

Hopefully I can have time next week to delve deeper into the good points you mentioned.

sounds good! ✨

kierancap · 2025-03-27T21:51:15Z

Just had a read through some other known React 19 OSS projects - They seem to be using forwardRef still - Even though the React team has specifically mentioned it being removed in future and is currently labeled as deprecated. In that case I'll revert my forwardRef changes as it should still function for the current React 19 version - Will get to that next week 😃

dagatsoin

Hi, just a quick first pass. I stopped on the forwardRef as it has already a big impact. Tell me your though.

dagatsoin · 2025-04-01T13:32:27Z

docs/app/components/Header/HeaderSidePanel.tsx

@@ -10,7 +10,6 @@ import { MenuDocs } from '../Menu/MenuDocs'

 import { NavigationSchema } from '../../../scripts/docs/navigation'
 import { SiteThemePicker } from '../Site/SiteThemePicker'
-import { forwardRef } from 'react'


breaking change: this may break react version < 19.

According to the react doc, forwardRef is still supported until further notice. We should keep it.

Yep agreed - I plan to revert these forwardRef changes when I can!

dagatsoin · 2025-04-01T13:38:38Z

package.json

@@ -95,8 +95,8 @@
    "mock-raf": "npm:@react-spring/[email protected]",
    "prettier": "3.4.2",
    "pretty-quick": "4.0.0",
-    "react": "18.3.1",
-    "react-dom": "18.3.1",
+    "react": "19.0.0",


deps: is locking to 19.0.0 not to restrictive? What about accepting at least patch or even minor version offset? (same question for the type)

I was mainly following the previous setup - As it was locked to that specific React 18 version, happy to change it though

Ho my bad, I did not see it was a dev dependencies.
However, all the packages' peerDependencies are needed to be updated to React 19 (I assume ^19.0.0 ?)

kierancap and others added 7 commits March 20, 2025 13:39

feat: Bumped deps and refactored usages of forwardRef

3a8e509

feat: disabled workflows

6c4240d

feat: Refactored SpringContext

065de58

feat: Reverted testing change

1d22c9e

formatting: useSprings

0c88ea4

Merge pull request #2 from Capventis/1-feat-react-19

6fb1346

feat: Bumped deps and refactored usages of forwardRef

ci: enabled workflows again

c78dad7

vercel bot deployed to Preview March 20, 2025 15:23 View deployment

kierancap mentioned this pull request Mar 20, 2025

feat: React 19 support #2349

Draft

3 tasks

charlieux mentioned this pull request Mar 25, 2025

React 19 support #2341

Open

5 tasks

dagatsoin mentioned this pull request Apr 1, 2025

[bug]: Dependency resolution error when attempting to install with the latest version of React #2362

Open

5 tasks

dagatsoin suggested changes Apr 1, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat: React 19 Upgrade #2363

Feat: React 19 Upgrade #2363

kierancap commented Mar 20, 2025 •

edited

Loading

changeset-bot bot commented Mar 20, 2025

vercel bot commented Mar 20, 2025 •

edited

Loading

thomazcapra commented Mar 25, 2025

abriginets commented Mar 25, 2025

johansunden commented Mar 27, 2025

kierancap commented Mar 27, 2025

joshuaellis commented Mar 27, 2025

kierancap commented Mar 27, 2025

joshuaellis commented Mar 27, 2025

kierancap commented Mar 27, 2025

dagatsoin left a comment

dagatsoin Apr 1, 2025

kierancap Apr 1, 2025

dagatsoin Apr 1, 2025

kierancap Apr 1, 2025

dagatsoin Apr 2, 2025 •

edited

Loading

Feat: React 19 Upgrade #2363

Are you sure you want to change the base?

Feat: React 19 Upgrade #2363

Conversation

kierancap commented Mar 20, 2025 • edited Loading

Why

What

Checklist

Additional Comments

PR Diff

changeset-bot bot commented Mar 20, 2025

⚠️ No Changeset found

vercel bot commented Mar 20, 2025 • edited Loading

thomazcapra commented Mar 25, 2025

abriginets commented Mar 25, 2025

johansunden commented Mar 27, 2025

kierancap commented Mar 27, 2025

joshuaellis commented Mar 27, 2025

kierancap commented Mar 27, 2025

joshuaellis commented Mar 27, 2025

kierancap commented Mar 27, 2025

dagatsoin left a comment

Choose a reason for hiding this comment

dagatsoin Apr 1, 2025

Choose a reason for hiding this comment

kierancap Apr 1, 2025

Choose a reason for hiding this comment

dagatsoin Apr 1, 2025

Choose a reason for hiding this comment

kierancap Apr 1, 2025

Choose a reason for hiding this comment

dagatsoin Apr 2, 2025 • edited Loading

Choose a reason for hiding this comment

kierancap commented Mar 20, 2025 •

edited

Loading

vercel bot commented Mar 20, 2025 •

edited

Loading

dagatsoin Apr 2, 2025 •

edited

Loading